Skip to content

feat: add ownership option to device formatting #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Johnson-zs merged 1 commit into from
Jul 28, 2025
Merged

feat: add ownership option to device formatting #36

Johnson-zs merged 1 commit into from
Jul 28, 2025

Conversation

@itsXuSt
Copy link
Contributor

@itsXuSt itsXuSt commented Jul 26, 2025 •
edited by sourcery-ai bot
Loading

  • Updated the device formatting options to include a new parameter "take-ownership" set to true.
  • This enhancement allows for better management of device ownership during formatting.

Log: Added ownership option to device formatting.

Bug: https://pms.uniontech.com/bug-view-325935.html

Summary by Sourcery

New Features:

  • Add 'take-ownership' option to device formatting to allow claiming device ownership during format operations

@itsXuSt
feat: add ownership option to device formatting
e06debc 
- Updated the device formatting options to include a new parameter "take-ownership" set to true.
- This enhancement allows for better management of device ownership during formatting.

Log: Added ownership option to device formatting.

Bug: https://pms.uniontech.com/bug-view-325935.html
@sourcery-ai
Copy link

sourcery-ai bot commented Jul 26, 2025

Reviewer's Guide

This PR enhances the device formatting routine by extending the formatting options map to include a new "take-ownership" parameter set to true, enabling ownership management during format operations.

Class diagram for updated device formatting options in MainWindow

classDiagram
    class MainWindow {
        +void formatDevice()
    }
    class MainPage {
        +QString getLabel()
        +QString getSelectedFs()
        +bool shouldErase()
    }
    class Blk {
        +void format(QString fs, QVariantMap opt)
        +QDBusError lastError()
    }
    MainWindow --> MainPage : uses
    MainWindow --> Blk : uses

    %% Highlight the change: opt now includes "take-ownership"
    note for MainWindow "formatDevice now adds { 'take-ownership': true } to options map for format() call"
Loading

File-Level Changes

Change Details Files
Introduce ownership flag in formatting options
  • Added "take-ownership" key with value true to the formatting options map
 view/mainwindow.cpp
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Jul 26, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @itsXuSt - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin-ci-robot commented Jul 26, 2025

deepin pr auto review

关键摘要:

  • 在QVariantMap中添加了"take-ownership"键值对，需要确认这是否符合预期的功能需求。
  • 检查m_mainPage->shouldErase()的返回值是否为true或false，以确保逻辑正确。

是否建议立即修改:

  • 是，需要确保新增的"take-ownership"参数符合设计意图，并且shouldErase()方法的返回值是预期的。

@Johnson-zs Johnson-zs merged commit f27a936 into linuxdeepin:master Jul 28, 2025
17 checks passed
@deepin-ci-robot
Copy link

deepin-ci-robot commented Jul 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: itsXuSt, Johnson-zs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@Johnson-zs Johnson-zs Johnson-zs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@itsXuSt @deepin-ci-robot @Johnson-zs